Fix "Add" label to "New" #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan C. Borchardt <[email protected]>
jancborchardt
added
regression
jancborchardt
requested review from
juliusknorr,
marcoambrosini,
skjnldsv,
susnux and
szaimen
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 3 3
Lines 76 76
Branches 13 13
=======================================
Hits 70 70
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
szaimen
approved these changes
Nov 15, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Pushed a fix for the tests which should hopefully be green now
Signed-off-by: Simon L <[email protected]>
szaimen
force-pushed
the
fix/new-label
branch
from
306d0d0 to
81f323a
Compare
juliusknorr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in chat with @szaimen
This is fixing a regression because the label we introduced was called "New" and is supposed to be that cause most actions in it are "New …".