Skip to content

Make sure to pass all props and attributes to single-action Actions #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 2, 2021
Merged

Make sure to pass all props and attributes to single-action Actions #1809

skjnldsv merged 1 commit into from
Apr 2, 2021

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 31, 2021

Only a very narrow set of attributes were passed to the element if only one action were displayed.

Example (the download is NOT applied to the action without this PR):

<ActionLink
	download="123456"
	icon="icon-download"
	:close-after-click="true"
	:href="currentFile.davPath">
	{{ t('viewer', 'Download') }}
</ActionLink>

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Mar 31, 2021
@skjnldsv skjnldsv self-assigned this Mar 31, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 31, 2021
Merged
@skjnldsv skjnldsv requested a review from jotoeri April 2, 2021 09:00
jotoeri
jotoeri approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks good. 👍

@skjnldsv skjnldsv merged commit 332c71b into master Apr 2, 2021
@skjnldsv skjnldsv deleted the fix/single-action-attributes branch April 2, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@korelstar korelstar Awaiting requested review from korelstar

@julien-nc julien-nc Awaiting requested review from julien-nc

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

+1 more reviewer

@jotoeri jotoeri jotoeri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @raimund-schluessler @jotoeri