add custom modal size option #2273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szaimen <[email protected]>
szaimen
force-pushed
the
enh/noid/add-custom-modal-size
branch
from
b029e66 to
06abb41
Compare
szaimen
added
3. to review
szaimen
requested review from
Pytal,
artonge,
jancborchardt,
marcoambrosini and
nimishavijay
Contributor
|
What is the use case for this? I would advise against this, also since mentioned in #2126 (comment) there are already plenty (too many) modal sizes. |
Contributor
Author
|
Fine by me. |
Contributor
Author
|
done that in #2274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: szaimen [email protected]