Button accessibility improvements #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
added
3. to review
marcoambrosini
requested review from
CarlSchwan,
JuliaKirschenheuter,
PVince81,
danxuliu,
julien-nc,
juliusknorr and
nickvergessen
marcoambrosini
force-pushed
the
button-accessibility-improvements
branch
from
8ccf0c1 to
cfc9a66
Compare
juliusknorr
reviewed
Jul 28, 2022
marcoambrosini
force-pushed
the
button-accessibility-improvements
branch
from
cfc9a66 to
d0fabaa
Compare
JuliaKirschenheuter
approved these changes
Jul 29, 2022
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
tested on mail - works! Thank you!
Contributor
Lots of issues on CI |
marcoambrosini
force-pushed
the
button-accessibility-improvements
branch
2 times, most recently
from
04b28bf to
c274f01
Compare
Contributor
Should be fixed now that the server doesn't simply touch everything anymore: |
marcoambrosini
force-pushed
the
button-accessibility-improvements
branch
from
c274f01 to
e44571b
Compare
Contributor
Author
Still, all that is not needed anymore. |
marcoambrosini
force-pushed
the
button-accessibility-improvements
branch
from
e44571b to
3265136
Compare
Contributor
Author
|
Let's get this in? |
skjnldsv
approved these changes
Sep 6, 2022
Contributor
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Isn't the black border a tad too strong? :)
Otherwise fine by me
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Contributor
|
Rebasing... |
skjnldsv
force-pushed
the
button-accessibility-improvements
branch
from
26e62bf to
2e0c711
Compare
skjnldsv
added
4. to release
Signed-off-by: Marco Ambrosini <[email protected]>
skjnldsv
force-pushed
the
button-accessibility-improvements
branch
from
2e0c711 to
36e82ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of simplification and accessibility fixes for the Button component.
!importantalways activates thefocus-visiblewhen navigating with the keyboard)focusfeedback. There's already a huge outline, so best avoid reducing contrasttertyary-no-backgroundbuttons. These are buttons whose use we should limit for very specific use-case such as within an input field. The only hover feedback will be thecursorchange topointer, while for keyboard navigation we have the beefy outline here too.Screen.Recording.2022-07-28.at.12.26.12.mov