Skip to content

Conversation

@marcoambrosini
Copy link
Contributor

Signed-off-by: Marco Ambrosini [email protected]

Signed-off-by: Marco Ambrosini <[email protected]>
@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Aug 4, 2022

@marcoambrosini I don't think that this is necessary. The cypress check ran just fine on GitHub (and now fails with the updated snapshots).

The problem you experience is probably that the tests fail locally for you (as well as for me). This is due to a different environment on GitHub and our local systems which makes the snapshots look subtly different. I didn't really figure out a way to solve this yet (besides running it in a Docker container both remotely and locally, but this was quite a bit more complex than what we have currently).

So for now, our ground truth for the snapshots has to be the remote GitHub check. If you want them updated, you need to run the GitHub cypress check, download the new snapshots and commit them.

@PVince81
Copy link
Contributor

PVince81 commented Aug 4, 2022

tests passed fine on #2929 a few minutes ago, and this was rebased on master, so the snapshots on master must be fine

@PVince81 PVince81 closed this Aug 4, 2022
@raimund-schluessler raimund-schluessler deleted the update-cypress-snapshots branch August 4, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: testing Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants