Skip to content

Always show NcAppSettingsDialog title #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Aug 19, 2022
Merged

Always show NcAppSettingsDialog title #3074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0b8d1
Always show NcAppSettingsDialog title
raimund-schluessler Aug 19, 2022
0fd0aff
Align AppSettingsDialog title with close button
raimund-schluessler Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,13 +323,11 @@ export default {
},
}, [
// app-settings title
this.title
? h('h2', {
attrs: {
class: 'app-settings__title',
},
}, this.title)
: undefined,
h('h2', {
attrs: {
class: 'app-settings__title',
},
}, this.title),

// app-settings navigation + content
h(
Expand Down Expand Up @@ -372,7 +370,10 @@ export default {
flex-direction: column;
min-width: 0;
&__title {
padding-top: 12px;
min-height: $clickable-area;
height: $clickable-area;
line-height: $clickable-area;
padding-top: 4px; // Same as the close button top spacing
text-align: center;
}
&__wrapper {
Expand Down