Skip to content

Improve text fields #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raimund-schluessler merged 1 commit into from
Sep 1, 2022
Merged

Improve text fields #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/NcInputField/NcInputField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,13 @@
<label v-if="!labelOutside && label !== undefined"
class="input-field__label"
:class="{ 'input-field__label--hidden': !labelVisible }"
:for="inputName">
:for="computedId">
{{ label }}
</label>
<div class="input-field__main-wrapper">
<input v-bind="$attrs"
:id="computedId"
ref="input"
:name="inputName"
class="input-field__input"
:type="type"
:disabled="disabled"
Expand Down
20 changes: 19 additions & 1 deletion src/components/NcPasswordField/NcPasswordField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ export default {
:success="computedSuccess"
:minlength="rules.minlength"
:trailing-button-label="trailingButtonLabel"
:disabled="disabled"
v-on="$listeners"
@trailing-button-click="togglePasswordVisibility"
:disabled="disabled"
@input="handleInput">
<!-- Default slot for the leading icon -->
<slot />
Expand Down Expand Up @@ -279,6 +279,24 @@ export default {
type: Boolean,
default: false,
},

/**
* Mark the password field as required
*/
required: {
type: Boolean,
default: false,
},

/**
* Name of the text field
*
* This is the key that will be send when sending a form
*/
name: {
type: String,
default: undefined,
},
},

emits: [
Expand Down
101 changes: 101 additions & 0 deletions src/components/NcTextField/NcTextField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,107 @@ export default {
type: String,
default: '',
},

/**
* Disable the text field
*/
disabled: {
type: Boolean,
default: false,
},

/**
* Name of the text field
*
* This is the key that will be send when sending a form
*/
name: {
type: String,
default: undefined,
},

/**
* Helps the browser identify the type of text field and to provide
* better autocompletion.
*/
autocomplete: {
type: String,
validator: (value) => [
'on',
'off',
'name',
'honorific-prefix',
'given-name',
'additional-name',
'family-name',
'honorific-suffix',
'nickname',
'email',
'username',
'organization-title',
'organization',
'street-address',
'address-line1',
'address-line2',
'address-line3',
'address-level4',
'address-level3',
'address-level2',
'address-level1',
'country',
'country-name',
'postal-code',
'cc-name',
'cc-given-name',
'cc-additional-name',
'cc-family-name',
'cc-number',
'cc-exp',
'language',
'bday',
'bday-day',
'bday-month',
'bday-year',
'sex',
'tel',
'impp',
'url',
'photo',
].includes(value),
default: 'on',
},

/**
* Define hows the mobile browser should capitalize the text input
*/
autocapitalize: {
type: String,
default: 'sentences',
validator: (value) => [
'none',
'off',
'on',
'sentences',
'words',
'characters',
].includes(value),
},

/**
* Allow to disable spellchecking
*/
spellcheck: {
type: Boolean,
default: true,
},

/**
* Mark the text field as required
*/
required: {
type: Boolean,
default: false,
},
},

emits: [
Expand Down