Skip to content

Limit max width of the settings #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
Sep 8, 2022
Merged

Limit max width of the settings #3192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/components/NcSettingsSection/NcSettingsSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,16 @@ This component is to be used in the settings section of nextcloud.
<NcSettingsSection
title="Two-Factor Authentication"
description="Two-factor authentication can be enforced for all users and specific groups."
doc-url="https://docs.nextcloud.com/server/19/go.php?to=admin-2fa">
Your settings here
doc-url="https://docs.nextcloud.com/server/19/go.php?to=admin-2fa"
:limit-width="true">
<p>Your settings here</p>
</NcSettingsSection>
</template>
```
</docs>

<template>
<div class="settings-section">
<div class="settings-section" :class="{'settings-section--limit-width': limitWidth}">
<h2 class="settings-section__title">
{{ title }}
<a v-if="hasDocUrl"
Expand Down Expand Up @@ -85,6 +86,16 @@ export default {
type: String,
default: '',
},
/**
* Limit the width of the setting's content
*
* By default only the title and description have a limit, use this
* property to also apply this to the rest of the content.
*/
limitWidth: {
type: Boolean,
default: true,
},
},

data() {
Expand All @@ -108,6 +119,8 @@ export default {
</script>

<style lang="scss" scoped>
$maxWidth: 900px;

.settings-section {
display: block;
margin-bottom: auto;
Expand All @@ -117,12 +130,17 @@ export default {
border-bottom: 1px solid var(--color-border);
}

&--limit-width > * {
max-width: $maxWidth;
}

&__title {
display: inline-flex;
align-items: center;
justify-content: center;
font-size: 20px;
font-weight: bold;
max-width: $maxWidth;
}

&__info {
Expand All @@ -145,6 +163,7 @@ export default {
margin-top: -.2em;
margin-bottom: 1em;
opacity: $opacity_normal;
max-width: $maxWidth;
}
}

Expand Down