Fix overwriting placeholder property in NcDatetimePicker #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you remove the Then, regarding the components, we have in this PR:
|
Chartman123
force-pushed
the
fix/NcDatetimePicker_placeholder
branch
from
a5056f4 to
72d3404
Compare
Chartman123
force-pushed
the
fix/NcDatetimePicker_placeholder
branch
from
72d3404 to
c034b32
Compare
Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
fix/NcDatetimePicker_placeholder
branch
from
a7d7b73 to
dae7c21
Compare
jotoeri
approved these changes
Sep 8, 2022
CarlSchwan
approved these changes
Sep 9, 2022
Contributor
Author
|
Should we also backport this to the current releases? |
Contributor
|
/backport to stable6 |
Contributor
This broke the component: fix in #3405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in Forms where the placeholder for NcDatetimePicker cannot be overwritten by passing some text to the property: nextcloud/forms#1296
Signed-off-by: Christian Hartmann [email protected]