Allow opting out of automatic NcModal remounting #3219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Pytal
added
3. to review
Pytal
requested review from
PVince81,
skjnldsv and
szaimen
and removed request for
a team
Pytal
added
the
accessibility
PVince81
approved these changes
Sep 12, 2022
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 makes sense considering the reasons
GretaD
approved these changes
Sep 16, 2022
This was referenced Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic remounting behaviour of NcModal is not always desired so we allow passing
nullto prevent this and to keep NcModal mounted at the initial mount point on the DOMMore context in nextcloud-libraries/nextcloud-password-confirmation#387