-
Notifications
You must be signed in to change notification settings - Fork 95
Add minlength and maxlength to text field #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you! Looks much cleaner now 🧹 |
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
/rebase |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
a607b2a to
0cb466f
Compare
blizzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Add
minlengthandmaxlengthto be forwarded to the input byv-bind="$props"The part which adds the
autofocusprop definition is an addendum to #3245Before this change
autofocuswasn't contained in$propsso it wasn't automatically forwarded byv-bind="$props", adding the explicit definition now makes it get forwarded by thev-bindand also makes the prop show up in the docs