Fix empty content height in NcDashboardWidget in N in N in N #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
JuliaKirschenheuter and
mejo-
and removed request for
a team
Contributor
|
This does not work on my side. In the screenshot, the Mattermost widget is linked with your PR's branch of The Mattermost widget empty content is selected in the inspector.
Removing the top margin by setting it to 0 works for me. |
artonge
previously requested changes
Oct 17, 2022
Use padding instead of margin Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
fix/empty-content-height
branch
from
5e22f53 to
857e250
Compare
skjnldsv
approved these changes
Oct 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use padding instead of margin
Fix nextcloud/server#34582