Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Nov 23, 2022
@skjnldsv skjnldsv added this to the 7.1.0 milestone Nov 23, 2022
@skjnldsv skjnldsv requested review from a team, GretaD and szaimen November 23, 2022 09:47
@skjnldsv skjnldsv self-assigned this Nov 23, 2022
@skjnldsv skjnldsv requested review from PVince81 and artonge and removed request for a team November 23, 2022 09:47
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

I suppose this fixes #3306?

@skjnldsv skjnldsv merged commit 7dd77d8 into master Nov 23, 2022
@skjnldsv skjnldsv deleted the fix/multiselect-checkmark branch November 23, 2022 09:58
@skjnldsv
Copy link
Contributor Author

I suppose this fixes #3306?

yep

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

@skjnldsv can you maybe create a new vue lib release that contains this fix? :)

@skjnldsv
Copy link
Contributor Author

@szaimen you can do it :)

@szaimen
Copy link
Contributor

szaimen commented Nov 23, 2022

@szaimen you can do it :)

I can check tomorrow morning how to do that. Was there some documentation on this somewhere? Also do I have enough permissions to publish the release to npm?

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 23, 2022

@szaimen szaimen mentioned this pull request Nov 24, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

#3515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants