Allow using v-show for NcModal, fix modal-wrapper transition
#3769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/ncmodal-show-prop
branch
2 times, most recently
from
3c95c30 to
6c11a61
Compare
raimund-schluessler
changed the title
v-showNcModal, fix modal-wrapper transition
raimund-schluessler
requested review from
Pytal,
artonge,
marcoambrosini,
nickvergessen,
skjnldsv and
susnux
raimund-schluessler
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
raimund-schluessler
force-pushed
the
fix/ncmodal-show-prop
branch
from
73bce8f to
e997a5d
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
raimund-schluessler
force-pushed
the
fix/ncmodal-show-prop
branch
from
e997a5d to
edbaf0b
Compare
Contributor
Author
|
@susnux Everything should work now. |
Signed-off-by: Raimund Schlüßler <[email protected]>
artonge
approved these changes
Feb 20, 2023
susnux
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to toggle the modal visibility by setting the
showprop of the modal, which will keep the modal in the DOM.It also fixes the transition animation of the modal-wrapper when showing/hiding the modal with
v-if.Checkout the docs https://deploy-preview-3769--nextcloud-vue-components.netlify.app/#/Components/NcModal and enjoy a smooth modal wrapper animation 😉
@susnux I think this is the best version of the solution now, as it allows to use
v-show / :show.sync="modal"orv-if, fixes the transition animations for both and requires no watcher.Fixes #497.