Skip to content

fix(NcActionInput): Fix multi select in NcActionInput #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickvergessen wants to merge 1 commit into from
Closed

fix(NcActionInput): Fix multi select in NcActionInput #3795

nickvergessen wants to merge 1 commit into from

Conversation

@nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Feb 20, 2023

Before After
Scrolling is a nightmare Scrolling works reasonably well
grafik grafik

The visuals are still broken, but at least it's not [object Object] anymore.

Can someone help with the layering?

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 20, 2023
@nickvergessen nickvergessen added this to the 7.7.0 milestone Feb 20, 2023
@nickvergessen nickvergessen self-assigned this Feb 20, 2023
@nickvergessen nickvergessen mentioned this pull request Feb 20, 2023
Closed
@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Feb 20, 2023

You guys don't like #3760 huh? 🙈

@nickvergessen
Copy link
Contributor Author

nickvergessen commented Feb 20, 2023

You guys don't like #3760 huh? 🙈

Sorry, I just updated to the latest version, got the bug reported went to the lib and fixed it.
Would not have thought that there is a pending PR for a bug like this.

@nickvergessen
Copy link
Contributor Author

nickvergessen commented Feb 20, 2023

We can cherry-pick my documentation part to yours and merge that?

@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Feb 20, 2023

We can cherry-pick my documentation part to yours and merge that?

Fine with me. 👍

@nickvergessen
Copy link
Contributor Author

nickvergessen commented Feb 20, 2023

I will send a commit to your PR to add the sample

@ChristophWurst ChristophWurst deleted the bugfix/noid/fix-multiselect-usage-in-action-input branch February 20, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Milestone

7.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @raimund-schluessler @ChristophWurst