Skip to content

NcSelect: Only hide search input if disabled and an element was selected #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raimund-schluessler merged 1 commit into from
Feb 28, 2023
+6 −5
Merged

NcSelect: Only hide search input if disabled and an element was selected #3833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(NcSelect): Only hide search input if disabled and an element was … 
…selected

This fixes a regression where the placeholder text is not shown
if configured to be not searchable.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Feb 28, 2023
commit c350a6659a2e146e91429239a567b7ddd66c8476
11 changes: 6 additions & 5 deletions src/components/NcSelect/NcSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,13 +1008,14 @@ body {
}
}

// Hide search from dom if unused to prevent unneeded flex wrap
.vs__search[readonly] {
position: absolute;
}
// If search if hidden, ensure that the height of the search is the same
.vs__selected-options {
// If search is hidden, ensure that the height of the search is the same
min-height: 40px; // 36px search height + 4px search margin

// Hide search from dom if unused to prevent unneeded flex wrap
.vs__selected ~ .vs__search[readonly] {
position: absolute;
}
}

/**
Expand Down