Skip to content

Conversation

@Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet [email protected]

Disables background color and pointer cursor while hovering this area with mouse.

2023-04-05_15-07

Signed-off-by: Jérôme Herbinet <[email protected]>

Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet
Copy link
Member Author

@szaimen this PR replaces nextcloud/server#35625
Do I need here to do a "npm run build" ?

box-sizing: border-box;
width: 100%;
&.app-navigation-entry__settings-quota {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt this rather go into thr server repo? Also cc @skjnldsv

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not the right place here.

Also we have apps that hook into the quota and make it clickable (external sites app). So not sure we want to prevent this at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmpf, that being said it's broken already in 26

@szaimen
Copy link
Contributor

szaimen commented Apr 5, 2023

Do I need here to do a "npm run build" ?

No, not needed here

@szaimen szaimen added the 3. to review Waiting for reviews label Apr 5, 2023
@szaimen szaimen requested a review from a team April 5, 2023 14:36
@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 6, 2023

Not the right place, besides, the hover is here for a reason.
If you click it refreshes the quota. So there is an action.
Until this is removed (when all views are migrated to vue and we can rely on files events only), the hover should stay :)

@skjnldsv skjnldsv closed this Apr 6, 2023
@Jerome-Herbinet
Copy link
Member Author

OK @skjnldsv , I didn't know that...
So I have a suggestion: You should at least add a tooltip when you move your mouse over the page, for example: "Refresh" ... because I think there are a lot of people like me who didn't understand the usefulness of this.

@Jerome-Herbinet Jerome-Herbinet deleted the patch-6 branch August 31, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants