Better readability of long file and event names #4194
Conversation
Jerome-Herbinet
requested review from
jancborchardt,
juliusknorr,
nimishavijay and
skjnldsv
Jerome-Herbinet
added
3. to review
|
"npm run cypress:update-snapshots" ran successfully, but Cypress / Runner 1 (and 2) still crash. Don't know why. |
|
You need to download and commit the snapshots that the Github action created: https://github.com/nextcloud/nextcloud-vue/suites/13434227827/artifacts/736443982 |
@raimund-schluessler |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Note that in the new screenshots all the words are underlined in red by the spellchecker. It is better to take screenshots when you switch the system language to English - or alternatively add those words to the dictionary. :) (cc @szaimen to whom I mentioned the issue before too)
There was a problem hiding this comment.
Vertical alignment is off here (also before)
There was a problem hiding this comment.
Vertical alignment is off here (also before)
|
I'm looking to this old PR. |
Because The best would be to rebase to current |
|
I rebased the branch and add cypress files, but I can't push because I don't have the write rights : git remote add upstream-2 https://github.com/nextcloud-libraries/nextcloud-vue.git |
ShGKme
force-pushed
the
Jerome-Herbinet-patch-better-readability-of-long-files-and-events-names
branch
from
68d2cbb to
d024222
Compare
|
@ShGKme ; can you help me with new conflicts ? |
Jerome-Herbinet
added
design
|
@jancborchardt after testing NC 29 (should be the same with NC 30) :
I close this PR |
jancborchardt
deleted the
Jerome-Herbinet-patch-better-readability-of-long-files-and-events-names
branch
|
@Jerome-Herbinet cool, thanks for checking and updating! :) |
fixes: #4210
Respawn of old PR #3295 (which encountered a cypress:update-snapshots problem)
Currently, on the right side panel, the labels end too easily with ellipsis dots. This is, from my personal and professional experience, too restrictive because we often cannot see the continuation of the file or event name (potentially also in any other similar case using this "vue"). It's a pain especially in Nextcloud Calendar but in Nextcloud Files too and probably in other apps.
I propose, with this change, to allow 3 lines to be displayed before the ellipsis.
Nextcloud Calendar test :
Nextcloud Files test :
Note :
My only point of hesitation concerns the management of long (or even very long) unbreakable words with the "hyphens" CSS property, which sometimes causes a hyphen to appear just above the suspension points.