fix(NcModal): Some modal improvments #4645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting `display: none` The buttons are placed absolute, therefor they do not interact with the modal container and content. Meaning even if only on button is shown the modal is centered correctly. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
bug
susnux
requested review from
Antreesy,
artonge,
raimund-schluessler and
szaimen
…tent Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ncmodal-improvments
branch
from
5bdefc8 to
4c5b411
Compare
…ert by content Also ensure that the close button fit into the modal. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ncmodal-improvments
branch
from
4c5b411 to
865dbb2
Compare
raimund-schluessler
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
display: noneThe buttons are placed absolute, therefor they do not interact with the modal container and content.
Meaning even if only on button is shown the modal is centered correctly.
The modal height is max. 90%, but if the window is not that tall or the modal is tall, then the header might overlap the content. So fix this by setting the modal max. height to 100% - 2*modal-header (because of the centered placement).
🖼️ Screenshots
You can see the header no longer overflows the content. And the button is on top of the modal content even if the default content margin of 50px is overridden.
And for the revert of the visibility hack, here is a "after" screenshot with only on button, you can see it is still centered perfectly:
🏁 Checklist