fix: If a aria-selected button is present we focus on this one instead of the first entry #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of the first entry Signed-off-by: Julius Härtl <[email protected]>
3 tasks
skjnldsv
approved these changes
Oct 20, 2023
JuliaKirschenheuter
approved these changes
Oct 20, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Härtl [email protected]
☑️ Resolves
Fixes nextcloud/text#3864
I checked and it seems we cannot easily or nicely change the initial focus of the NcActions entires. (unless we consider using setTimeout an option) within text. Now we don't have a real active state in the NcAction* components which we could use to pick the initial focus element, however since this initial focus handling is mostly bound to accessibility I decided to make a change of the initial focus depending on if any NcAction* entry is indicating a selected state with
aria-selected.🏁 Checklist