fix(NcAppNavigation): Ensure --app-navigation-padding is set also on app-content
#4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n app-content Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
bug
susnux
requested review from
ShGKme,
raimund-schluessler,
skjnldsv and
szaimen
16 tasks
JuliaKirschenheuter
approved these changes
Nov 8, 2023
skjnldsv
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fix regression of #4730
We can not use scoped here because it will set a different scope than on the NcAppContent and thus the css variable will not be injected into it.
(One of the reasons I do not like scoped but prefer
module).🏁 Checklist