Skip to content

fix: Do not depend on uncompiled vue files as dependencies #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Nov 8, 2023
Merged

fix: Do not depend on uncompiled vue files as dependencies #4777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@
"vue": "^2.7.14",
"vue-color": "^2.8.1",
"vue-frag": "^1.4.3",
"vue-material-design-icons": "^5.1.2",
"vue2-datepicker": "^3.11.0"
},
"engines": {
Expand Down Expand Up @@ -143,6 +142,7 @@
"url-loader": "^4.1.1",
"vite": "^4.3.9",
"vue-eslint-parser": "^9.0.3",
"vue-material-design-icons": "^5.2.0",
"vue-router": "^3.6.5",
"vue-styleguidist": "~4.72.0",
"vue-template-compiler": "^2.7.14",
Expand Down
7 changes: 5 additions & 2 deletions vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,12 @@ export default defineConfig((env) => {
const createConfig = createLibConfig(entryPoints, {
// Add our overrides to the config
config: overrides,
// Packages with paths imports should be added here to mark them as external as well
// By default all dependencies are external, but no path imports
nodeExternalsOptions: {
include: [/^vue-material-design-icons\//, /^@nextcloud\/.+\//, /^@mdi\/svg\//],
// Packages with paths imports should be added here to mark them as external as well
include: [/^@nextcloud\/.+\//, /^@mdi\/svg\//],
// Make sure to not provide uncompiled vue files as dependencies, this will break unit tests
exclude: [/\.vue(\?|$)/],
},
// For backwards compatibility we include the css within the js files
inlineCSS: true,
Expand Down