fix(NcAppNavigation): remove background square connecting toggle and navigation #4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
16 tasks
susnux
approved these changes
Nov 8, 2023
jancborchardt
approved these changes
Nov 8, 2023
Contributor
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good!
Btw, unrelated but the left navigation could use a border-right to separate for narrow screens. On desktop itnis separated by the glass-look, but on mobile there is no separation between the backgrounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
See: #4767 (comment)
Returns transparency between the app navigation and the toggle. Only the toggle button has a background.