chore: Release 8.4.0 #4987

ShGKme · 2023-12-22T17:01:05Z

v8.4.0 (2023-12-22)

Full Changelog

Notes

NcRichContenteditable: new visual label feature might break layout if you have custom contenteditable styles
isMobile and isFullscreen mixins are now deprecated, use useIsMobile and useIsFullscreen composables instead

🚀 Enhancements

enh: Split translations by components to only include needed strings in app bundles by @susnux in enh: Split translations by components to only include needed strings in app bundles #4861
enh(NcCheckboxRadioSwitch): Allow to set aria-label by @susnux in enh(NcCheckboxRadioSwitch): Allow to set aria-label #4903
enh(NcRichContenteditable): Add optional visual label for content editable by @susnux in enh(NcRichContenteditable): Add optional visual label for content editable #4907
enh(NcBreadcrumbs): Allow setting aria-label on nav by @Pytal in enh(NcBreadcrumbs): Allow setting aria-label on nav #4913
feat: add small mobile breakpoint by @ShGKme in feat: add small mobile breakpoint #4919
Add target prop for NcListItem by @fenn-cs in Add target prop for NcListItem #4923
Make modal mask dark if some icons are shown outside by @szaimen in Make modal mask dark if some icons are shown outside #4916
enh: Add a full labelled color palette to be used as the default for the color picker by @susnux in enh: Add a full labelled color palette to be used as the default for the color picker #4902

🐛 Fixed bugs

fix(NcAppNavigationItem): fix style when using active prop by @raimund-schluessler in fix(NcAppNavigationItem): fix style when using active prop #4989
fix(NcDialog): Increase specificity for modal-content selector by @susnux in fix(NcDialog): Increase specificity for modal-content selector #4897
Prevent NcBreadcrumb from automatically inheriting attributes by @JuliaKirschenheuter in Prevent NcBreadcrumb from automatically inheriting attributes #4918
fix(NcAvatar): Increase contrast of avatar status icon by @Pytal in fix(NcAvatar): Increase contrast of avatar status icon #4912
fix(utils/UserStatus): typo in "invisible" translation key by @ShGKme in fix(utils/UserStatus): typo in "invisible" translation key #4931
enh(NcDialog): Label dialog nav by @Pytal in enh(NcDialog): Label dialog nav #4928
fix(NcAppNavigationSettings): remove incorrect aria-label by @ShGKme in fix(NcAppNavigationSettings): remove incorrect aria-label #4932
fix(NcAppSidebar): add focus trap on mobile by @ShGKme in fix(NcAppSidebar): add focus trap on mobile #4909
feat(NcRichContenteditable): put caret in the end when focus input by @Antreesy in feat(NcRichContenteditable): put caret in the end when focus input #4924
fix(package): specify exports for composables by @ShGKme in fix(package): specify exports for composables #4951
fix(NcActions): provide aria-expanded="false" when menu is closed instead of removing it by @ShGKme in fix(NcActions): provide aria-expanded="false" when menu is closed instead of removing it #4946
fix(NcListItem): Ensure list item does not overflow wrapper by @susnux in fix(NcListItem): Ensure list item does not overflow wrapper #4956
fix(NcActionX): Allow relative icon URL by @susnux in fix(NcActionX): Allow relative icon URL #4955
fix(NcAppSettingsDialog): respect showNavigation prop by @ShGKme in fix(NcAppSettingsDialog): respect showNavigation prop #4954
fix(NcAppNavigation): Bring back hover state for active element by @susnux in fix(NcAppNavigation): Bring back hover state for active element #4960
enh(aria): changed check color to adhere to 3:1 ratio by @emoral435 in enh(aria): changed check color to adhere to 3:1 ratio #4958
Use logical style for NcHeaderMenu by @ahangarha in Use logical style for NcHeaderMenu #4965
Equalize TextArea styles with TextField styles by @JuliaKirschenheuter in Equalize TextArea styles with TextField styles #4971
Increase contrast on input field for NcRichContenteditable by @JuliaKirschenheuter in Increase contrast on input field for NcRichContenteditable #4975
enh(breadcrumbs): changed aria label for voice control on a-tag by @emoral435 in enh(breadcrumbs): changed aria label for voice control on a-tag #4973
Differentiate between dark and light theme for NcDateTimePickerNative by @JuliaKirschenheuter in Differentiate between dark and light theme for NcDateTimePickerNative #4981

Other Changes

refactor(NcAppSidebar): remove unneeded debug log by @ShGKme in refactor(NcAppSidebar): remove unneeded debug log #4952
chore(ci): make Jest output colorful by @ShGKme in chore(ci): make Jest output colorful #4966
Update translations

ChristophWurst · 2023-12-22T17:05:38Z

Is this the first release with full Vue 3 support? #3692 (comment)

ShGKme · 2023-12-22T17:08:05Z

Is this the first release with full Vue 3 support? #3692 (comment)

No, we should make v9.0.0-alpha.1 release later from next branch.

ShGKme · 2023-12-22T17:08:31Z

But I forgot to mention deprecated stuff in the changelog.

ahangarha · 2023-12-22T18:22:43Z

Let me know if you think we should have logical CSS properties fully added in this release, and you can wait for one more week. Otherwise, they will be added in the next release.

ahangarha

I have a proposition for changing the category of #4965

ahangarha · 2023-12-22T18:27:16Z

CHANGELOG.md

+* fix(NcAppSettingsDialog): respect showNavigation prop by @ShGKme in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4954
+* fix(NcAppNavigation): Bring back hover state for active element by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4960
+* enh(aria): changed check color to adhere to 3:1 ratio by @emoral435 in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4958
+* Use logical style for NcHeaderMenu by @ahangarha in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4965


I am not sure if this PR should be categorized under bug fixes. I see it more as adding new capability to the UI to adjust itself to the direction of its context.

I think it is a bug if it does not work for some languages?

I'd call it definitely a bug fix. The component didn't work correctly. A new feature is a new component/function or new feature of a component with a new property/event and ect.

ShGKme · 2023-12-22T18:35:19Z

Let me know if you think we should have logical CSS properties fully added in this release, and you can wait for one more week. Otherwise, they will be added in the next release.

We always can make a new library release when needed, so we can just make 8.4.1 release next week or in 2 weeks. Next Nextcloud server release is planned for 25 Jan 2024 anyway.

susnux · 2023-12-22T18:38:23Z

But we can also wait for next year to get some more in as there will not much updating anyways

ahangarha · 2023-12-22T19:21:03Z

Nextcloud server release is planned for 25 Jan 2024 anyway.

In any case, I would like to have all the logical style fixes before the NextCloud-server release so that it can use these styles. In any case, I should hurry up 🙂 🏃🏾‍♂️

Signed-off-by: Grigorii K. Shartsev <[email protected]>

ShGKme · 2023-12-27T13:18:27Z

Rebased on master and to include one bug fix and great split translations enh.

ShGKme added the 2. developing Work in progress label Dec 22, 2023

ShGKme requested review from AndyScherzinger, ChristophWurst, JuliaKirschenheuter, skjnldsv and susnux December 22, 2023 17:01

ShGKme self-assigned this Dec 22, 2023

ShGKme force-pushed the release/v8.4.0 branch from 2acf786 to bae2530 Compare December 22, 2023 17:10

AndyScherzinger approved these changes Dec 22, 2023

View reviewed changes

ahangarha suggested changes Dec 22, 2023

View reviewed changes

susnux approved these changes Dec 22, 2023

View reviewed changes

JuliaKirschenheuter approved these changes Dec 27, 2023

View reviewed changes

chore: Release 8.4.0

14616d8

Signed-off-by: Grigorii K. Shartsev <[email protected]>

ShGKme force-pushed the release/v8.4.0 branch from bae2530 to 14616d8 Compare December 27, 2023 13:07

ShGKme marked this pull request as ready for review December 27, 2023 13:08

ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 27, 2023

ShGKme added this to the 8.4.0 milestone Dec 27, 2023

raimund-schluessler approved these changes Dec 27, 2023

View reviewed changes

ShGKme merged commit 7d1831a into master Dec 27, 2023

ShGKme deleted the release/v8.4.0 branch December 27, 2023 13:18

chore: Release 8.4.0 #4987

chore: Release 8.4.0 #4987

Uh oh!

Conversation

ShGKme commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v8.4.0 (2023-12-22)

Notes

🚀 Enhancements

🐛 Fixed bugs

Other Changes

Uh oh!

ChristophWurst commented Dec 22, 2023

Uh oh!

ShGKme commented Dec 22, 2023

Uh oh!

ShGKme commented Dec 22, 2023

Uh oh!

ahangarha commented Dec 22, 2023

Uh oh!

ahangarha left a comment

Choose a reason for hiding this comment

Uh oh!

ahangarha Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

susnux Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

ShGKme Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

ShGKme commented Dec 22, 2023

Uh oh!

susnux commented Dec 22, 2023

Uh oh!

ahangarha commented Dec 22, 2023

Uh oh!

ShGKme commented Dec 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ShGKme commented Dec 22, 2023 •

edited

Loading