fix(NcCheckboxRadioSwitch): fix shift+click on firefox #4999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
skjnldsv
force-pushed
the
fix/checkbox-label-shift-click-FF
branch
2 times, most recently
from
218637b to
0ec6083
Compare
emoral435
approved these changes
Dec 27, 2023
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
I actually primarily use Firefox, and am working on an issue that needs this resolved, so this is perfect. LGTM, works on my dev env, and keeps the aria label logic clean :)
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Dec 27, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
fix/checkbox-label-shift-click-FF
branch
from
0ec6083 to
ff8dff1
Compare
ShGKme
approved these changes
Dec 28, 2023
Contributor
|
But I'd add a comment in the code with a link to the bug, because it seems non-obvious why a native element is not used here. |
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/server#42202
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=559506
I'm not sure, if anyone else have a better idea, please suggest it! 🙏 🥲