enh(a11y): added aria-label that matches title attr on icon #5078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
added
enhancement
emoral435
requested review from
JuliaKirschenheuter,
ShGKme,
raimund-schluessler and
susnux
raimund-schluessler
approved these changes
Jan 16, 2024
raimund-schluessler
deleted the
enh/a11y/42855/add-aria-label-to-help-circle
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ For nextcloud/server#42855
Once the nextcloud/vue8.5.0 releases a,d the server repository gets the new library update, then the servers issue will be properly fixed!
Summary
Adds an aria label to all sections that use NcSettings Section
Example ^ This now has an aria label. Since the icon has no text, it needs a label AND a title for accessibility
🏁 Checklist