fix(NcButton): use a as tag for router-link
#5091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
raimund-schluessler
requested review from
Pytal,
ShGKme,
emoral435,
skjnldsv and
susnux
raimund-schluessler
added
3. to review
raimund-schluessler
force-pushed
the
fix/5089/button-link
branch
from
4115a85 to
c3c1438
Compare
ShGKme
approved these changes
Jan 18, 2024
Contributor
|
Thanks! |
emoral435
approved these changes
Jan 18, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Fixes the issue / regression that I (sorry) ade, so it looks good to me :) nice catch!
Signed-off-by: Raimund Schlüßler <[email protected]>
emoral435
force-pushed
the
fix/5089/button-link
branch
from
c3c1438 to
22a76f0
Compare
Contributor
Author
Don't worry, I had a good share in creating the problem 😆 🙈 And we found it before a release, so no harm was done anyway. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcButtonto render anaif thetoprop is provided instead of abuttonas before. This is the expected behaviour (for me) and fixesNcBreadcrumbdoes not render<a>anymore whentois provided #5089.