feat(NcReferenceList): Add support for a fallback reference widget #5092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
added
enhancement
raimund-schluessler
added
3. to review
juliusknorr
approved these changes
Jan 23, 2024
juliusknorr
force-pushed
the
feat/reference_list_fallback
branch
from
0770c17 to
5e78c00
Compare
max-nextcloud
approved these changes
Jan 23, 2024
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good. Have not tested it though.
What would this look like in use?
Allow to render a fallback widget if no other reference widget loads. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
feat/reference_list_fallback
branch
from
5e78c00 to
45ecc91
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to render a fallback widget if no other reference widget loads.
🏁 Checklist