fix(NcSelect): remove visual gap on top of the list #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
requested review from
ChristophWurst,
JuliaKirschenheuter,
Pytal,
raimund-schluessler and
susnux
ShGKme
force-pushed
the
fix/nc-select--annoying-gap
branch
from
2875c01 to
ed467df
Compare
Contributor
Author
|
This annoyed me every day 🙈 |
raimund-schluessler
requested changes
Jan 18, 2024
Contributor
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
Nice, I wasn't aware that box-shadow could be used for this 👍
But it needs a minor adjustment to work properly when the select opens to the top, see here:
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/nc-select--annoying-gap
branch
from
ed467df to
1819981
Compare
Contributor
Author
|
@raimund-schluessler thanks! |
raimund-schluessler
approved these changes
Jan 18, 2024
Pytal
approved these changes
Jan 18, 2024
Contributor
Pytal
left a comment
Pytal
left a comment
There was a problem hiding this comment.
🤯 available since Chrome 10!
Pytal
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
outlineshows a border on all the sides, including the top, which looks like a gap.Using
box-shadowallows adding outline only on 3 sides, except the top.🖼️ Screenshots
🏁 Checklist