feat(NcProgressBar): add circular progress bar #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
enhancement
raimund-schluessler
force-pushed
the
feat/noid/circular-progress
branch
from
5a67132 to
88e2bcc
Compare
raimund-schluessler
requested review from
Pytal,
ShGKme,
jancborchardt,
nimishavijay and
susnux
szaimen
approved these changes
Jan 21, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM from design perspective. Thanks for implementing this! :)
ShGKme
reviewed
Jan 21, 2024
ShGKme
reviewed
Jan 21, 2024
ShGKme
reviewed
Jan 21, 2024
ShGKme
approved these changes
Jan 21, 2024
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Cool!
Just some docs/a11y comments
Contributor
Author
|
Should be adjusted now. |
susnux
approved these changes
Jan 22, 2024
raimund-schluessler
force-pushed
the
feat/noid/circular-progress
branch
from
6ff20fa to
5fe91d9
Compare
ShGKme
approved these changes
Jan 22, 2024
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feat/noid/circular-progress
branch
from
5fe91d9 to
6425e8c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcProgressBar. For this I added thetypeprop to switch betweenlinearandcircularwithlinearbeing the default. I also added acolorprop, to give it a custom color.🖼️ Screenshots
No visual changes to existing components, no breaking changes.
Used in the Tasks app it looks like this:
