Remove inaccessible opacity from SettingsSection #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
Pytal,
ShGKme,
emoral435,
susnux and
szaimen
szaimen
approved these changes
Jan 22, 2024
ShGKme
reviewed
Jan 22, 2024
JuliaKirschenheuter
force-pushed
the
fix/42941-remove-inaccessible-opacity
branch
from
13857d0 to
d5a9db2
Compare
ShGKme
reviewed
Jan 22, 2024
susnux
requested changes
Jan 22, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Please do not use color-text-lighter
JuliaKirschenheuter
force-pushed
the
fix/42941-remove-inaccessible-opacity
branch
from
d5a9db2 to
1c20d8f
Compare
ShGKme
approved these changes
Jan 22, 2024
emoral435
approved these changes
Jan 22, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Haven't tested this on my local dev env to check , but it looks good to me!
Signed-off-by: julia.kirschenheuter <[email protected]>
emoral435
force-pushed
the
fix/42941-remove-inaccessible-opacity
branch
from
1c20d8f to
406d698
Compare
susnux
approved these changes
Jan 22, 2024
susnux
added
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Opacity is a bad choice for a11y in general. Let's remove it.
🖼️ Screenshots
🏁 Checklist