fix(NcRichText): Make URL_PATTERN match localhost and URLs with ports #5176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
ShGKme
approved these changes
Jan 29, 2024
max-nextcloud
approved these changes
Jan 30, 2024
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for adding the tests.
Maybe one thing to clarify (see below).
E.g. the file reference widget should work with links to Nextcloud on localhost. Also add some basic unit tests to prevent regressions with the regexes in the future. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/reference_url_pattern
branch
from
11aa3db to
55aa36f
Compare
mejo-
added a commit
to nextcloud/server
that referenced
this pull request
Mar 5, 2024
E.g. the file reference widget should work with links to Nextcloud on localhost. This adjusts the URL pattern regexes in server to be in sync with the ones in `@nextcloud/vue`. See nextcloud-libraries/nextcloud-vue#5176 for further details. Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
to nextcloud/server
that referenced
this pull request
Mar 5, 2024
E.g. the file reference widget should work with links to Nextcloud on localhost. This adjusts the URL pattern regexes in server to be in sync with the ones in `@nextcloud/vue`. See nextcloud-libraries/nextcloud-vue#5176 for further details. Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
to nextcloud/server
that referenced
this pull request
Mar 6, 2024
E.g. the file reference widget should work with links to Nextcloud on localhost. This adjusts the URL pattern regexes in server to be in sync with the ones in `@nextcloud/vue`. See nextcloud-libraries/nextcloud-vue#5176 for further details. Signed-off-by: Jonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. the file reference widget should work with links to Nextcloud on localhost.
Also add some basic unit tests to prevent regressions with the regexes in the future.
🏁 Checklist