fix(NcListItem): compensate added margin for list items #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
Antreesy
requested review from
JuliaKirschenheuter,
ShGKme,
emoral435 and
susnux
ShGKme
approved these changes
Feb 19, 2024
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
An alternative - make the outline inside the list item to have true 100% width. I'm almost sure, we did it in a similar place already...
emoral435
approved these changes
Feb 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
awhich caused invalid HTML output #5198🖼️ Screenshots
Tested against Talk
🏁 Checklist
nextrequested with a Vue 3 upgrade