add fallBackFocus to NcPopover #5440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
fix/no-fallback-focus
branch
from
a9fd852 to
2cf3ff1
Compare
juliusknorr
reviewed
Mar 26, 2024
| } | ||
| const el = this.getPopoverContentElement() | ||
| el.tabIndex = -1 |
Contributor
There was a problem hiding this comment.
Should we only set it if there is no existing tab index?
juliusknorr
approved these changes
Mar 26, 2024
Contributor
|
/backport to next |
susnux
approved these changes
Apr 1, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
makes sense also from documentation of focus trap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Focus-Trap library will throw an error if a trap does not have any elements it can focus. Therefore we need something to set focus on if there's nothing else to use. In the documentation it is recommended to give the container a tab-index of -1 to make it focusable but not appear in the tab flow, and then set that as the fallBack to focus on when theres nothing else in the container.