Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 11, 2024

☑️ Resolves

!!expression returns boolean and cannot return undefined/null anyway. And if it is falsy, then it is false already.

[plugin:vite:esbuild] [plugin vite:esbuild] src/functions/reference/widgets.ts: The "??" operator here will always return the left operand
42 |  
43 |  export const hasFullWidth = (id: string) => {
44 |    return !!window._vue_richtext_widgets[id]?.fullWidth ?? false
   |                                                        ^
45 |  }
46 | 

@ShGKme ShGKme requested review from juliusknorr and susnux April 11, 2024 10:03
@juliusknorr juliusknorr merged commit dab6602 into master Apr 12, 2024
@juliusknorr juliusknorr deleted the chore/widgets--remove-unneeded-nullish branch April 12, 2024 06:27
@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 12, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants