fix(autolink): correctly handle relative links without webroot #5487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
Antreesy
reviewed
Apr 12, 2024
Antreesy
approved these changes
Apr 12, 2024
DorraJaouad
approved these changes
Apr 15, 2024
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/autolink--correctly-handle-relative-links
branch
from
a32060f to
7b81387
Compare
Contributor
Author
|
/backport to next |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
I just realized that relative links should be considered relative to the Nextcloud instance, not origins.
For example, for the page
http://cloud.ltd/nextcloud/index.php/apps/files/favorites, the relative link should be/apps/files/favorites, not/nextcloud/index.php/apps/files/favorites.getRouteTests for all the cases looks a bit messy, but I don't know how to make it better.
🏁 Checklist
nextrequested with a Vue 3 upgrade