[next] fix(NcCheckboxRadioSwitch): Pass attrs to input if available
#5508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
Contributor
|
On vue3 this requires special handling, as |
susnux
force-pushed
the
backport/5507/next
branch
from
b906971 to
9c951c1
Compare
susnux
approved these changes
Apr 20, 2024
ShGKme
reviewed
Apr 21, 2024
susnux
force-pushed
the
backport/5507/next
branch
3 times, most recently
from
21ae8f6 to
e361276
Compare
ShGKme
reviewed
Apr 22, 2024
susnux
force-pushed
the
backport/5507/next
branch
from
e361276 to
c31eef3
Compare
susnux
force-pushed
the
backport/5507/next
branch
2 times, most recently
from
a16f5ec to
c868c41
Compare
Contributor
|
@ShGKme anything more needed? :) |
susnux
force-pushed
the
backport/5507/next
branch
from
c868c41 to
cc13d76
Compare
Antreesy
approved these changes
Jul 8, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks fine and aligned with last comments / original PR
If not button type, pass the attrs to the input element to allow setting aria tags like `aria-invalid` and `aria-errormessage` Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/5507/next
branch
from
cc13d76 to
8debebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5507
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.