-
Notifications
You must be signed in to change notification settings - Fork 95
style(NcSelect): restrict max-height to prevent overflow by component #5551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I'd do it even smaller by default, e.g. 2.5 lines.
|
Probably we need a different component to handle it. Something like GitHub's label dialog where you can search. |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Agree with @ShGKme that a height of 2.5 lines would be nicer.
Signed-off-by: Maksim Sukharev <[email protected]>
e791ad2 to
471cfaf
Compare
|
UPD: reduce max-height to 100px (2.5 - 2.6 visible lines) Github-styled labels is a good idea, but it's more a feature-level change (restyle of NcSelectTags wouldn't be enough, IMO), so I'd fix existing component first |
|
/backport to next |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Antreesy! :)
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
nextrequested with a Vue 3 upgrade