feat: add nextcloud-vue-import-transform script #5731
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
feat/import-transform-script
branch
from
60eade1 to
0ec1c7c
Compare
Contributor
|
Maybe it makes sense to have this in the eslint plugin or so? |
susnux
approved these changes
Jun 22, 2024
Contributor
Author
Makes sense but I wanted to play with different apps to see if it actually makes result better, not worse. |
Contributor
As soon as you use But this is especially helpful for libraries that are later used by Webpack, like nc dialogs. |
Antreesy
reviewed
Aug 30, 2024
|
|
||
| const MIXIN_NAMES = ['clickOutsideOptions', 'isFullscreen', 'isMobile', 'richEditor', 'userStatus'] | ||
| const DIRECTIVE_NAMES = ['Focus', 'Linkify', 'Tooltip'] | ||
| const modulesMap = { |
Contributor
There was a problem hiding this comment.
Any chance to update this map automatically?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vueimports nextcloud/firstrunwizard#1262Imports from re-export are not optimal, having tree-shaking issues
Individual imports are more optimal
But changing it manually is painful for a huge app.
This script makes it automatically and tells if some imports cannot be processed.
Example