feat(NcAppNavigation): Provide consistent in-app search #5831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
Contributor
Author
|
/backport to next |
susnux
force-pushed
the
feat/app-navigation-search
branch
2 times, most recently
from
dccdc53 to
aa44c07
Compare
ShGKme
reviewed
Jul 18, 2024
susnux
force-pushed
the
feat/app-navigation-search
branch
2 times, most recently
from
fd420ff to
b24b457
Compare
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
feat/app-navigation-search
branch
from
b24b457 to
296a074
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Jul 22, 2024
ShGKme
reviewed
Jul 22, 2024
AndyScherzinger
approved these changes
Jul 22, 2024
ShGKme
reviewed
Jul 22, 2024
ShGKme
reviewed
Jul 22, 2024
ShGKme
reviewed
Jul 22, 2024
susnux
force-pushed
the
feat/app-navigation-search
branch
from
59fc155 to
fae0202
Compare
`NcAppNaviation` now provides an optional in-app search when `show-search` is set. This allows apps which have in app filtering / search to use a consistent layout. There is also an actions slot to provide some inline actions like filters. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-navigation-search
branch
from
b28f617 to
f582bae
Compare
Co-authored-by: Grigorii K. Shartsev <[email protected]> Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-navigation-search
branch
from
f582bae to
eacab9a
Compare
ShGKme
reviewed
Jul 22, 2024
2 tasks
This was referenced Jul 22, 2024
| } | ||
| &__body { | ||
| overflow-y: scroll; |
Contributor
There was a problem hiding this comment.
What's the idea behind this? It causes scrolling in Mail:
Contributor
There was a problem hiding this comment.
replace <template #default> with <template #search>
Contributor
Author
There was a problem hiding this comment.
replace
<template #default>with<template #search>
Only if for the search component
Contributor
Author
There was a problem hiding this comment.
What's the idea behind this? It causes scrolling in Mail:
To have the app navigation scroll but not the search, see this:
#5831 (comment)
But I see, we should fix this.
This was referenced Jul 25, 2024
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcAppNaviationnow provides an optional in-app search whenshow-searchis set. This allows apps which have in app filtering / search to use a consistent layout.🖼️ Screenshots
vokoscreenNG-2024-07-18_17-02-03.webm
🏁 Checklist
nextrequested with a Vue 3 upgrade