Skip to content

fix(NcAppNavigation): keep border only on mobile #6008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Aug 22, 2024
Merged

fix(NcAppNavigation): keep border only on mobile #6008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/NcAppNavigation/NcAppNavigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ export default {
background-color: var(--color-main-background-blur, var(--color-main-background));
-webkit-backdrop-filter: var(--filter-background-blur, none);
backdrop-filter: var(--filter-background-blur, none);
border-inline-end: 1px solid var(--color-border);

&--close {
margin-left: calc(-1 * min($navigation-width, var(--app-navigation-max-width)));
Expand Down Expand Up @@ -389,10 +388,18 @@ export default {
}
}

// Add extra border for high contrast mode
[data-themes*="highcontrast"] {
.app-navigation {
border-inline-end: 1px solid var(--color-border);
}
}

// When on mobile, we make the navigation slide over the NcAppContent
@media only screen and (max-width: $breakpoint-mobile) {
.app-navigation {
position: absolute;
border-inline-end: 1px solid var(--color-border);
}
}

Expand Down