fix(NcHeaderMenu): Remove padding from popover menu #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be no padding within the popover menu. The popover container is not styleable (at least not without hacking the (not exposed-)CSS classes), so users can not remove the padding themself. The padding is a problem if the content is scrollable, because the scrollbar should be on the very end of the container and not floating around. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
bug
susnux
requested review from
Antreesy,
jancborchardt,
marcoambrosini and
skjnldsv
Contributor
Author
|
/backport to next |
4 tasks
jancborchardt
approved these changes
Aug 30, 2024
Contributor
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Yesss, looks so much better also in the People menu indeed. :)
skjnldsv
approved these changes
Aug 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
There should be no padding within the popover menu. The popover container is not style-able (at least not without hacking the (not exposed-)CSS classes), so users can not remove the padding themself.
The padding is a problem if the content is scroll-able, because the scrollbar should be on the very end of the container and not floating around.
🖼️ Screen recording
🏚️ Before
Bildschirmaufnahme_20240830_002829.webm
🏡 After
Bildschirmaufnahme_20240830_002718.webm
🏁 Checklist
nextrequested with a Vue 3 upgrade