fix(NcRichContenteditable): support email mentions #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
bug
nickvergessen
approved these changes
Nov 19, 2024
9 tasks
susnux
approved these changes
Nov 19, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
OK, but would feel better if you add unit tests
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/mention-emails
branch
from
ca5489a to
cbd2a6a
Compare
Contributor
Author
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade