feat(NcPopover): add new noFocusTrap prop
#6807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the `focusTrap` prop to have prop with default of `false` allowing to use HTML short cut attributes `<NcPopover no-focus-trap />`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
Signed-off-by: Ferdinand Thiessen <[email protected]>
ShGKme
approved these changes
Apr 18, 2025
Antreesy
approved these changes
Apr 18, 2025
Contributor
Author
|
/backport b58d97a to stable8 |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
floating-vuewrapper #6802☑️ Resolves
@nextcloud/vue v9breaking changes #6384Replacing the
focusTrapprop to have prop with default offalseallowing to use HTML short cut attributes<NcPopover no-focus-trap />.🏁 Checklist
stable8for maintained Vue 2 version or not applicable