Skip to content

fix(NcActions): allow to close popover on click outside #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
May 27, 2025
Merged

fix(NcActions): allow to close popover on click outside #6959

susnux merged 2 commits into from
May 27, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 26, 2025

☑️ Resolves

  1. We need to support HTML elements as boundary of NcPopover as this is used in multiple places
  2. We need to allow close on click outside
  3. Remove event listeners we do not emit anymore.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added this to the 9.0.0-rc.2 milestone May 26, 2025
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels May 26, 2025
@susnux susnux changed the title Fix/nc actions popover fix(NcActions): allow to close popover on click outside May 26, 2025
@susnux susnux requested review from ShGKme, artonge and skjnldsv May 26, 2025 16:30
ShGKme
ShGKme reviewed May 26, 2025
View reviewed changes
@susnux susnux requested a review from ShGKme May 26, 2025 19:11
@susnux susnux mentioned this pull request May 26, 2025
Merged
15 tasks
@susnux susnux merged commit 2972a7a into main May 27, 2025
25 checks passed
@susnux susnux deleted the fix/nc-actions-popover branch May 27, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Milestone

9.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

[NcActions] Popover does not close when clicked outside

4 participants

@susnux @skjnldsv @ShGKme