Skip to content

chore(NcAppContent): rename NcAppDetailsContent to remove from docs #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GretaD merged 2 commits into from
Jul 10, 2025
Merged

chore(NcAppContent): rename NcAppDetailsContent to remove from docs #7137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f5e19f
refactor(NcAppContent): rename NcAppDetailsContent to NcAppContentDet…
ShGKme Feb 23, 2024
c66724d
docs(NcAppContent): remove NcAppContentDetailsToggle from the docs
ShGKme Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/NcAppContent/NcAppContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
'app-content-wrapper--show-details': showDetails,
'app-content-wrapper--show-list': !showDetails,
'app-content-wrapper--mobile': isMobile,}">
<NcAppDetailsToggle v-if="showDetails" @click.stop.prevent="hideDetails" />
<NcAppContentDetailsToggle v-if="showDetails" @click.stop.prevent="hideDetails" />

<div v-show="!showDetails">
<slot name="list" />
Expand Down Expand Up @@ -153,7 +153,7 @@
import { APP_NAME } from '../../utils/appName.ts'
import { isRtl } from '../../utils/rtl.ts'

import NcAppDetailsToggle from './NcAppDetailsToggle.vue'
import NcAppContentDetailsToggle from './NcAppContentDetailsToggle.vue'

import 'splitpanes/dist/splitpanes.css'

Expand All @@ -170,7 +170,7 @@
name: 'NcAppContent',

components: {
NcAppDetailsToggle,
NcAppContentDetailsToggle,
Pane,
Splitpanes,
},
Expand Down Expand Up @@ -414,11 +414,11 @@
*
* @deprecated listen on `resize-list` instead
*/
this.$emit('resize:list', { size: listPaneSize })

Check warning on line 417 in src/components/NcAppContent/NcAppContent.vue

View workflow job for this annotation

GitHub Actions / eslint 

Custom event name 'resize:list' must be camelCase
/**
* Emitted when the list pane is resized by the user
*/
this.$emit('resize-list', { size: listPaneSize })

Check warning on line 421 in src/components/NcAppContent/NcAppContent.vue

View workflow job for this annotation

GitHub Actions / eslint 

Custom event name 'resize-list' must be camelCase
console.debug('AppContent pane config', listPaneSize)
},

Expand Down
0 ...nents/NcAppContent/NcAppDetailsToggle.vue → ...cAppContent/NcAppContentDetailsToggle.vue
View file
Open in desktop
File renamed without changes.
9 changes: 2 additions & 7 deletions styleguide.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ module.exports = async () => {
{
name: 'App containers',
components: [
'src/components/NcContent/*.vue',
'src/components/NcAppContent/NcAppContent.vue',
'src/components/NcContent/NcContent.vue',
],
sections: [
{
Expand All @@ -227,12 +228,6 @@ module.exports = async () => {
'src/components/NcAppNavigationItem/NcInputConfirmCancel.vue',
],
},
{
name: 'NcAppContent',
components: [
'src/components/NcAppContent*/*.vue',
],
},
{
name: 'NcAppSidebar',
components: [
Expand Down
Loading