Skip to content

feat(NcButton): add border with a bottom shadow #7282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 3 commits into from
Aug 17, 2025
Merged

feat(NcButton): add border with a bottom shadow #7282

susnux merged 3 commits into from
Aug 17, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 14, 2025 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ stable31 🏡 stable32
Screenshot 2025-08-14 at 18-06-28 Nextcloud Vue Style Guide Screenshot 2025-08-14 at 18-06-16 Nextcloud Vue Style Guide

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux requested review from CarlSchwan, ShGKme and kra-mo August 14, 2025 16:07
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Aug 14, 2025
@susnux susnux force-pushed the feat/button-border branch from c26988c to e510e31 Compare August 14, 2025 16:11
@susnux
Copy link
Contributor Author

susnux commented Aug 14, 2025

(pushed the window definition of OC.config.version)

@susnux susnux force-pushed the feat/button-border branch from 2369a3c to 12cb231 Compare August 14, 2025 17:11
@susnux
Copy link
Contributor Author

susnux commented Aug 14, 2025

/update-snapshots

@susnux susnux force-pushed the feat/button-border branch from 738c020 to 7c5f948 Compare August 14, 2025 17:18
@susnux susnux added the design Design, UX, interface and interaction design label Aug 14, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Aug 14, 2025

Looks like nothing changed on Netlify
image

@ShGKme
Copy link
Contributor

ShGKme commented Aug 14, 2025

feat: add border radius for buttons on legacy Nextcloud versions

Resolves: [NcButton] Add a slight shadow to buttons

PR title is a buit consufing in the context of the issue title...

@susnux susnux changed the title feat: add border radius for buttons on legacy Nextcloud versions feat: add border for buttons on legacy Nextcloud versions Aug 15, 2025
@kra-mo
Copy link
Member

kra-mo commented Aug 15, 2025

Could I see how this looks on hover/click? From what I can see though, looks good :)

@ShGKme
Copy link
Contributor

ShGKme commented Aug 15, 2025

Could I see how this looks on hover/click? From what I can see though, looks good :)

You can open the demo by clicking here:

image

@kra-mo
Copy link
Member

kra-mo commented Aug 15, 2025 •
edited
Loading

You can open the demo by clicking here

Oo, cool! I suppose when it does change.

@susnux susnux force-pushed the feat/button-border branch from 7c5f948 to edab525 Compare August 17, 2025 16:12
@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2025

Rebased - not sure why the preview was not correct as it already worked locally.
Now it seems to be also visible on the preview.

Notice that for error and success style it currently looks less discoverable, but we will have the correct behavior once nextcloud/server#54439 is merged.

@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2025

/update-snapshots amend

kra-mo
kra-mo approved these changes Aug 17, 2025
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. Maybe it could be a bit darker for primary to be more visible, but only if it wouldn’t complicate things :)

@susnux susnux force-pushed the feat/button-border branch from 11c6f0b to 7242cf5 Compare August 17, 2025 21:28
@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2025

/backport 11faa04 to stable8

@susnux susnux force-pushed the feat/button-border branch from 7242cf5 to 445ff53 Compare August 17, 2025 21:29
@susnux
Copy link
Contributor Author

susnux commented Aug 17, 2025

/update-snapshots amend

@nextcloud-command
test: update playwright snapshots
12b1cbe 
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 4e14ed7 into main Aug 17, 2025
25 checks passed
@susnux susnux deleted the feat/button-border branch August 17, 2025 22:15
@backportbot backportbot bot mentioned this pull request Aug 17, 2025
Merged
2 tasks
@ShGKme ShGKme changed the title feat: add border for buttons on legacy Nextcloud versions feat(NcButton): add border with a bottom shadow Aug 18, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Aug 18, 2025 •
edited
Loading

Renamed to add scope and removed the "legacy" part as this is not for legacy if I understood the code correctly (there are no checks to apply the changes only for older servers)

@Antreesy Antreesy mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@kra-mo kra-mo kra-mo approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NcButton] Add a slight shadow to buttons

6 participants

@susnux @ShGKme @kra-mo @CarlSchwan @nextcloud-command