-
Notifications
You must be signed in to change notification settings - Fork 0
Update rector to 2.0 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
|
The lowest tests fails because I did not set a minimum version for nextcloud/ocp I suppose. Maybe we can set that to 25 as that’s the oldest set we have? |
We have to require a version of nextcloud/ocp that contains the classes we use in the tested sets. Otherwise tests for 26 and 27 sets will fail when pulling the lowest version of dependendies. Signed-off-by: Côme Chilliet <[email protected]>
1c31a26 to
bbf5de8
Compare
I had to require 27 so that tests on 26 and 27 sets pass. |
|
So it has to be the highest supported version so all changes can be made? |
Yeah, seems like it.
For now maybe we can merge as-is, as 27 is not that recent and should be ok as a requirement for apps using nextcloud/rector? But yeah later when we populate sets for 31+ it’s gonna be a problem, so maybe we tackle it now 🤷 |
|
Sounds good to me, although we can and should prevent the ocp version conflict in apps by putting rector into vendor-bin. |
|
New release? @ChristophWurst |
Fix #34
Not sure about all the changes, I had to pull OCP so that rector finds the classes.
I had to delete my composer.lock and start from scratch, and I set platform php to 8.1 to avoid composer pulling a psalm too recent (otherwise it only runs on latest PHP).