This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Improve escape keypress handling #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
…ements to its focus trap Signed-off-by: Julien Veyssier <[email protected]>
Collaborator
Author
|
It works after emitting the |
max-nextcloud
approved these changes
Feb 7, 2023
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
I was not able to reproduce the behavior described as without this fix escape would close the entire viewer for me. Maybe I'm running an outdated server or viewer version.
With this fix the behavior seems correct. Thanks for the sleuthing. 🕵️
delete-merged-branch
bot
deleted the
fix/noid/ref-picker-escape-pressed
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Text, when opening the link picker without initial provider (via the menu action), then selecting a provider, then going back by pressing Escape, the provider multiselect can't be focused anymore.
I had a long fight to make progress but still no luck.
This works fine when used in RichContentEditable (and outside the Viewer btw).
I checked and the event does not go upper than
<ReferencePicker>.I tried using another key to go back and it works fine. So, for some reason, pressing Escape messes with the focus trap.