Allow resolve to follow symlinks #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that npm run watch will continue to update if a npm linked dependency changes Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
a team,
PVince81,
Pytal,
skjnldsv and
vinicius73
and removed request for
a team
Contributor
Author
|
Note that I'm unsure why this worked before, but I feel like some recent webpack update has changed default behavior |
skjnldsv
approved these changes
Aug 10, 2022
Contributor
|
👀 @JuliaKirschenheuter because you noticed that builds were not reactive with Calendar (uses this package) but worked fine with Mail (doesn't use this package) |
marcoambrosini
approved these changes
Aug 10, 2022
Pytal
approved these changes
Aug 10, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
There is also https://webpack.js.org/configuration/watch/#watchoptionsfollowsymlinks but that doesn't seem to have the desired effect, while both repostiories rebuild, the server repository doesn't use the latest state of the linked one then. |
juliusknorr
changed the title
Contributor
Author
|
Server related issues addressed with nextcloud/server#33517 / nextcloud-libraries/nextcloud-vue#3018 Requesting another review round as the approach changed |
Pytal
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that npm run watch will continue to update if a npm linked dependency changes
Signed-off-by: Julius Härtl [email protected]